Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated JSON test data files which would be used on Android Test Engine #2428

Closed
wants to merge 34 commits into from

Conversation

BEChiaha
Copy link

The PR is set to update the JSON test data files which would be used alongside by the Android E2E Test Engine to generate the necessary Android E2E test files.

Summarize the changes
If this Pull Request should close/resolve any issues when merged, use the special syntax for that here.

Main changes in the PR:

  1. Revised the required JSON test data files to specify their compatibility with the Android Test Engine for generating Android Test Files.
  2. Excluded certain test cases/test files that are not executable by the Android Test Engine on the Android SDK.
  3. Included android specific test cases in Location.json and Geolocation.json which could be used on the Android platform due to tackle issue with float parameter type in Location Data Class

Validation performed:

Ensured there are no typos

Unit Tests added:

None

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.
These are simply JSON files update, and no unit tests can be performed on these

<Yes/No>

End-to-end tests added:

No

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

<Yes/No>

Related PRs:

1)https://office.visualstudio.com/ISS/_git/metaos-hub-sdk-android/pullrequest/3190330?_a=files&path=/apps/orangeandroid/metaoshubsdk/src/main/java/com/microsoft/metaos/hubsdk/ui/BaseMetaOsViewModel.kt
2)https://office.visualstudio.com/ISS/_git/metaos-hub-sdk-android/pullrequest/3132297

@BEChiaha BEChiaha requested a review from a team as a code owner July 25, 2024 19:53
Copy link
Contributor

@TrevorJoelHarris TrevorJoelHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small stylistic changes

@BEChiaha
Copy link
Author

BEChiaha commented Jul 25, 2024

@microsoft-github-policy-service agree company="Microsoft"

jekloudaMSFT
jekloudaMSFT previously approved these changes Aug 6, 2024
@@ -31,6 +31,19 @@
{
"title": "getCurrentLocation API Call - Success",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference between the 2 "getCurrentLocation API Call - Success" tests here?

@TrevorJoelHarris
Copy link
Contributor

Checked with @jadahiya-MSFT and am closing this because it is no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants